[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] [PATCH 1/4] configure: Adjust indentations.

From: Lee Duhem
Subject: Re: [Tinycc-devel] [PATCH 1/4] configure: Adjust indentations.
Date: Thu, 27 Nov 2014 11:30:43 +0800

On Wed, Nov 26, 2014 at 8:02 PM, David Mertens <address@hidden> wrote:
> I don't believe that tcc has a whitespace policy (though it appears that
> nearly all indentation is with spaces in the C sources, and every once in a
> while a git mixed tabs+spaces where the tabs look like they are supposed to
> be eight characters wide).

Maybe we need a stricter code review policy.

>  As such, I would suggest minimizing the number of
> patches with whitespace changes. If you are going to cleanup whitespace (and
> your fourth patch makes it clear this is on your mind), I think all
> whitespace should be cleaned up in all files, in one go.

Good point. Maybe I should wait until I have read all of the source
files, then adjust
all the possible whitespace problems all at once.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]