[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] [PATCH 1/4] configure: Adjust indentations.

From: David Mertens
Subject: Re: [Tinycc-devel] [PATCH 1/4] configure: Adjust indentations.
Date: Wed, 26 Nov 2014 07:02:58 -0500

I don't believe that tcc has a whitespace policy (though it appears that nearly all indentation is with spaces in the C sources, and every once in a while a git mixed tabs+spaces where the tabs look like they are supposed to be eight characters wide). As such, I would suggest minimizing the number of patches with whitespace changes. If you are going to cleanup whitespace (and your fourth patch makes it clear this is on your mind), I think all whitespace should be cleaned up in all files, in one go.

The cleanups you have look fine by me, for what it's worth.


On Wed, Nov 26, 2014 at 3:38 AM, Lee Duhem <address@hidden> wrote:

Some adjustments miss in the previous patch,
here is the updated version.


On Wed, Nov 26, 2014 at 4:01 PM, Lee Duhem <address@hidden> wrote:
> Hi,
> This basically a code style improvement patch. Changes included
> in this patch:
> 1. adjust indentations;
> 2. make `configure --help` return success instead of failure;
> 3. remove some tailing spaces.
> Sincerely,
> lee

Tinycc-devel mailing list

 "Debugging is twice as hard as writing the code in the first place.
  Therefore, if you write the code as cleverly as possible, you are,
  by definition, not smart enough to debug it." -- Brian Kernighan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]