[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] [PATCH 4/4] tcc.[ch]: Adjust code style.

From: David Mertens
Subject: Re: [Tinycc-devel] [PATCH 4/4] tcc.[ch]: Adjust code style.
Date: Wed, 26 Nov 2014 06:54:01 -0500

Commits that change style should, in my opinion, be completely combined into a single patch. I would prefer if this were merged with the first patch.

As for the order of value checking, I do not think this is a good idea. These are classic Yoda Conditions and they should be kept that way to encourage the practice, in my opinion.


On Wed, Nov 26, 2014 at 3:15 AM, Lee Duhem <address@hidden> wrote:

This also basically is a code style adjustment patch.
Changes included in this patch:

1. remove tailing spaces;
2. adjust some spaces around operators;
3. replace `const == var` with `var == const`, to make
them consistent with the around code.

This patch should make the code style in tcc.[ch] more


Tinycc-devel mailing list

 "Debugging is twice as hard as writing the code in the first place.
  Therefore, if you write the code as cleverly as possible, you are,
  by definition, not smart enough to debug it." -- Brian Kernighan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]