[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] Request push

From: jiang
Subject: Re: [Tinycc-devel] Request push
Date: Wed, 02 Jul 2014 00:07:02 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

I'm sorry, I was remiss.
I did not find a space with gitk.
This is my new commit:89000c18dc7d5ccb2687948f94fe49d392990dab

Best regards,


Le dimanche 29 juin 2014, 16:56:31 Thomas Preud'homme a écrit :
Le dimanche 29 juin 2014, 12:32:57 大熊猫 a écrit :
Thank you Thomas, I hope you agree with my request.
Sure, as I said, provided that a testcase is added I'd be happy for you to
commit the patch.
Thanks for committing the patch Jiang. I have one comment: you should use a
different name for your testcase as you are not testing the concatenation. You
should name your tests macro_param_list or something like this.

Also a minor nitpick: you left a trailing whitespace in both testcase in the
line "int c = 0xa; ". It's not worth a commit in itself but since you will do
a commit to rename the test, please fix it at the same time. Before you push I
urge you to look at your diff with git. It will show you trailing whitespace by
default (if not you can activate it with git config --global core.whitespace

Best regards,


reply via email to

[Prev in Thread] Current Thread [Next in Thread]