Re: [Tinycc-devel] New warning on ARM since few commits

[Christian Jullien]

Thank you for your reply Michael

On RPi, I have a cron that hourly checks if tcc has got update and recompile 
from scratch in case of update. It sends me an email with log result

On Apr 7 01:03:36
Libtcc1.o was compiled using tcc that sees no issue

make[1]: Entering directory `/home/jullien/tinycc/lib'
mkdir -p arm
./tcc -B.. -c libtcc1.c -o arm/libtcc1.o -I..  -Wall -g -O2 
-fno-strict-aliasing -Wno-pointer-sign -Wno-sign-compare -Wno-unused-result 
-fPIC -DTCC_TARGET_ARM ./tcc -B.. -c armeabi.c -o arm/armeabi.o -I..  -Wall -g 
-O2 -fno-strict-aliasing -Wno-pointer-sign -Wno-sign-compare -Wno-unused-result 
-fPIC -DTCC_TARGET_ARM gcc -c alloca-arm.S -o arm/alloca-arm.o -I..  -Wall -g 
-O2 -fno-strict-aliasing -Wno-pointer-sign -Wno-sign-compare -Wno-unused-result 
-fPIC -DTCC_TARGET_ARM ar rcs ../libtcc1.a arm/libtcc1.o arm/armeabi.o 
arm/alloca-arm.o
make[1]: Leaving directory `/home/jullien/tinycc/lib'

12 hours later, on Apr 7 12:03:36 build toolchain has been changed to build 
libcc1.o with gcc which sees this bug

make[1]: Entering directory `/home/jullien/tinycc/lib'
mkdir -p arm
gcc -c libtcc1.c -o arm/libtcc1.o -I..  -Wall -g -O2 -fno-strict-aliasing 
-Wno-pointer-sign -Wno-sign-compare -Wno-unused-result -fPIC -DTCC_TARGET_ARM
libtcc1.c: In function ‘__fixunsxfdi’:
libtcc1.c:588:26: warning: ‘dl1.l.upper’ may be used uninitialized in this 
function [-Wuninitialized] gcc -c armeabi.c -o arm/armeabi.o -I..  -Wall -g -O2 
-fno-strict-aliasing -Wno-pointer-sign -Wno-sign-compare -Wno-unused-result 
-fPIC -DTCC_TARGET_ARM gcc -c alloca-arm.S -o arm/alloca-arm.o -I..  -Wall -g 
-O2 -fno-strict-aliasing -Wno-pointer-sign -Wno-sign-compare -Wno-unused-result 
-fPIC -DTCC_TARGET_ARM ar rcs ../libtcc1.a arm/libtcc1.o arm/armeabi.o 
arm/alloca-arm.o
make[1]: Leaving directory `/home/jullien/tinycc/lib'

It would be nice if ARM maintainers handle this with #ifndef TCC_TARGET_ARM as 
you suggest

Christian

-----Original Message-----
From: Michael Matz [mailto:address@hidden 
Sent: samedi 12 avril 2014 10:54
To: address@hidden
Cc: 'Christian JULLIEN'
Subject: Re: [Tinycc-devel] New warning on ARM since few commits

Hi,

On Sat, 12 Apr 2014, Christian Jullien wrote:

> No comments about this issue?

It shouldn't be a new warning.  The code in question (libtcc1.c, ldouble_long 
type, the __fixunsxfdi function, and the definition of LDOUBLE_SIZE for ARM) 
hasn't changed in ages.

> In fact, this warning is a real BUG if this function is called on ARM

Yes, but it never is.  long double size is always 8, and for that calls to the 
XFmode functions are never emitted.  You could as well simply add some #ifndef 
TCC_TARGET_ARM around the implementation of the *xfdi and *dixf functions in 
libtcc1.c.


Ciao,
Michael.