[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] improving get_tok_str

From: Domingo Alvarez Duarte
Subject: Re: [Tinycc-devel] improving get_tok_str
Date: Mon, 31 Mar 2014 22:45:58 +0100

About documentation and looking at the "Tiny code generator" http://wiki.qemu.org/Documentation/TCG/backend-ops and http://wiki.qemu.org/Documentation/TCG/frontend-ops , something like that for the actual tinycc would be useful for new people to understand code generation.

Cheers !

On Mon, Mar 31, 2014 at 4:46 PM, mobi phil <address@hidden> wrote:
Another alternative is: I could go through the code and add comments
in form of questions.

Please no. A git source code repository is not a wiki. Maybe some kind of code review platform would be nice: you could tag specific line in the code and ask for comments. I'd be open to participate to such an experiment. Although don't expect me to set this up.

Was not proposing to commit this into the main repo, just a very simple way to tag lines that probably need some more comments. 
The "experts" then just could do a diff and see those points, remove the tag and/or add comment. 
Thought this would be a very simple channel for this goal.

Do you have any specific code review platform, that could be well integrated with git and a simple editor like vim?
Can I push the result somewhere? I do not have mob access etc. Shall I
setup my own tcc git repo?

Everybody has mob access. That's the whole concept of mob access. But only pushes fix, features, etc… No questions in the code, even in a separate file.
Honestly never used mob. On http://repo.or.cz/h/mob.html, "only if you add a mob user and" statement made me thinking that I need
some access grant. Will read again the documentation.

Tinycc-devel mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]