[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Tinycc-devel] [PATCH] libtcc1.c: Fix 'Floating point exception' tes
Re: [Tinycc-devel] [PATCH] libtcc1.c: Fix 'Floating point exception' test failures
Tue, 10 Sep 2013 00:37:18 +0100
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8
On 10/09/13 00:03, Thomas Preud'homme wrote:
> Le lundi 9 septembre 2013 23:49:16 Ramsay Jones a écrit :
>> Since commit 73faaea2 ("i386-gen: preserve fp control word in
>> gen_cvt_ftoi", 28-08-2013) the tests have failed, like so:
>> address@hidden $ make test
> I think this commit message is very well explained but too detailed.
> along the line "correct operand constraint in __tcc_fpinit
> and __tcc_cvt_ftol" would be better I think. It's obvious from the fact that
> the constraints are wrong that gcc is doing wrong optimization. Or maybe I'm
> wrong but anyway, I already applied your commit so it's too late to change it
> now, sorry. I agree I didn't pay enough attention to the commit message.
Yeah, how much detail to put into the commit message can
vary greatly from one project to the next ...
However, the original patch I sent to Arnold didn't have
a commit message. It was a WIP patch that I wanted him to
try out, before I sent a real patch ... :-D
> Thanks a lot anyway.
Happy to help, when I can.