[Tinycc-devel] Re: [PATCH 7/7] tcc -E: Let output_default be <file>.o instead of a.out

[grischka]

Kirill Smelkov wrote:
> On Fri, Jun 18, 2010 at 09:24:28PM +0200, grischka wrote:
> > Did you consider pushing the feature(s) on the tinycc mob branch?
>
> Yes. And I though mob was a bit destabilized by "last member of union"
> patches, so I decided not to continue that.

Well, looks like he fixed something but broke something else instead.
I've reverted the commits for now.

> Yes, I've read tinycc.git intro text about mob, and it's really up to
> you on how to pick patches. I just though posting by mail is also ok,
> and as your comments show, having a look on them before inclusion allows
> (hopefully) to merge them in a bit more good shape.

Sure that is good ;)

But I will not push other peoples' patches.  So once you are happy
with what you did you need to do that yourself.  No need to hurry
though.

In any case you could push the simple fixes (typos etc) first, and
then the MD/MF patch as one single commit.

Also it is easier IMO to look at patches in the git webview.  Maybe
you can just post a link to your branch next time instead of sending
30 emails.

>  snprintf(buf, sizeof(buf), "%s", target);
tcc usually does "pstrcpy(buf, sizeof(buf), target);"

>  static char outfile_default[1024];
Hm hm ...

Anyway what I like about your new feature is that the main()
function now looks cleaner than before ;)

--- grischka