[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] Fix signedness of LL shift operators in libtcc1.c (gr

From: David A. Wheeler
Subject: Re: [Tinycc-devel] Fix signedness of LL shift operators in libtcc1.c (grischka-2005-09-25 case_10)
Date: Thu, 03 May 2007 22:00:16 -0400 (EDT)

Rob Landley:
> Hmmm...  Ideally we'd want it to automatically use this code when tcc was 
> compiling itself.  Is that when __TINYC__ is defined?  In which case, an 
> easier (or at least more logical) reproduction sequence would be:
> Or perhaps "make test2" or "make test3" should cover this...

If there's going to be a better way to generate the code itself, I suggest 
thinking about that and applying that as a SEPARATE patch which actually 
improves the build process itself.

The purpose of THIS patch is to fix signedness problems, and the only reason 
for the lengthy comment is to explain how to invoke the test "by hand".  The 
comment is mostly independent of the build process, which is a good thing for a 
comment.  Changing the build process is probably a big change, best handled 
separately, and in my experience it takes a while to create a good build 
process. No need to hold up fixing shift functions until the vunderbuild 
process arrives :-).

--- David A. Wheeler

reply via email to

[Prev in Thread] Current Thread [Next in Thread]