[Texmacs-dev] safely-close-window silently ignores unsaved buffers

[Norbert Nemec]

After repeated loss of data due to bugs in TeXmacs, I have taken the
time to investigate.

One result of this was patch #5519, which I hope will be incorporated
soon to avoid further data loss.

Another result is the following half-solved issue:

If some open buffer contains images (either linked or inserted), the
variable 'nr_windows', declared in src/Window/X/x_loop.cpp and modified
by the constructors and the destructor of 'x_window_rep' (in fiel
src/Window/X/x_window.cpp) is 1 larger than it should be.

The result: if only one TeXmacs window is open, (get-nr-windows) returns
2 and the function safely-kill-window (in
TeXmacs/procs/texmacs/texmacs/tm-server.scm) does not check for unsaved
buffers.

In other words: If the last texmacs window is closed using the X button
of the window manager (or Alt-F4 - my usual method of closing windows)
unsaved buffers are silently closed without saving.

Could others please confirm the problem:
* create file
* insert image
* do *not* save file
* a) File|Close TeXmacs should correctly ask for confirmation
  b) View|Close Window should erraneously quit without asking for
confirmation (alternatively click the X button in the frame or press
Alt-F4, depending on the Window manager)

I cannot make out where the problem originates. Hopefully, the
information given will help someone else to finally solve the problem
that has enerved for a long time now.

Greetings,
Norbert