[Texmacs-dev] Re: TeXmacs port to IRIX

[Philipp Tomsich]

On Sun, 12 Jan 2003, Joris van der Hoeven wrote:

> I CC'ed it to the other developers.

I've attached an initial diff-set (beware: these were by a script and thus
include diffs of auto-generated files such as configure), hoping that you and
the other developers will review those changes and include them, as you see
fit. It includes the followings changes:

  1. Recognition of systems running Irix in the configure phase; this
     includes the handling of specific flags to system utilities (chmod
     doesn't have a -f option on Irix), compiler flags and permiting
     non-GNU compilers. (I'll need to do some more work in this area to
     check whether a 7.4.x or higher compiler is used, as older compilers
     have issues with the c++ code).
  2. Changes to fix duplicate argument names in function prototypes.
  3. Removal of all uses of variable-length arrays from the C++ code.
     While C99 permits VLAs, the ISO C++ standard doesn't allow them (the
     currently discussed revision of the standard will support these, but
     it's probably going to be about 2 more years until that). Our compilers
     would allow VLAs for built-in types, but other may not. So I simply
     rewrote all occurences of this for the sake of consistency, standards
     conformance and portability.
  4. In a few cases I removed local variables that are set, but never used.
     There's more of them (I need to review my compiler messages for these).
  5. Reordering to code in the header files that use templates to avoid
     problems with references to friend methods that aren't declared yet.
  6. A few (2 or 3) explicit casts to type (X**) for the result of a
     "new (X*) [...]" operation to work around an apparent bug in our
     7.4 compilers (I've also given notice about this to our C++ front-end
     engineers).

Furthermore, I have a question regarding a code snippet in the guile-glue,
that I didn't want to spend too much time of, but which looks somewhat
questionable to me. The file src/Guile/Glue/glue.cc has the following code in
line 243:

    if ((N(s)>=2) && (s[0]=='\42') && (s[N(s)-1]='\42'))
      return string_to_scm (s (1, N(s)-1));

I was wondering whether, the last assignment was intended as a comparison.

--phil.

patches
Description: Text document