texinfo-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: texinfo-4.13.90 pre-pre-test

From: Stefano Lattarini
Subject: Re: texinfo-4.13.90 pre-pre-test
Date: Sat, 10 Nov 2012 11:51:36 +0100 
On 11/10/2012 01:03 AM, Patrice Dumas wrote:
> On Fri, Nov 09, 2012 at 09:31:59PM +0100, Stefano Lattarini wrote:
>> Hi Karl.
>>
>> On 11/09/2012 07:14 PM, Karl Berry wrote:
>>> If anyone here (especially you, Patrice :) has a chance to look ...
>>> I've temporarily put a tarball for the pretest at:
>>> http://freefriends.org/~karl/texinfo-4.13.90.xz
>>>
>> Typo here, BTW: s/.xz$/.tar.xz/
>>
>> Also, I notice Texinfo is still using the old, much inferior serial testsuite
>> harness provided by Automake.  I'd really advise you to switch to the 
>> parallel
>> harness instead, by passing the 'parallel-tests' option to AM_INIT_AUTOMAKE
>> (this harness will be the default starting from automake 1.13).
> 
> I'll leave that to Karl.
> 
>> NetBSD 5.1
>> ==========
>>
>>   The build hangs using /usr/bin/make:
>>
>>     $ make
>>     ...
>>     gcc  -g -O2   -o infokey infokey.o key.o ../gnulib/lib/libgnu.a
>>     Making all in po
>>     Making all in po_document
>>     Making all in tp
>>     Making all in .
>>     sed  -e 's,address@hidden@],4.13.90,g' ... ./ >texi2any
>>     chmod a+x texi2any
>>     ../build-aux/install-sh -c -d maintain
>>     sed -e 's|address@hidden@]|/home/slattarini/tmp/texinfo-4.13.90|' \
>>       > maintain/catalog.xml
>>     [HANGS HERE]
>>
>>   The problem disappears using GNU make though, so no big deal.
> 
> I can't see what's wrong with the rule above, but maybe it is a
> following rule that hangs?  Can you use a debug feature of BSD make
> to see what's going on?  If it is a bug of BSD make, it is not a big
> deal, but it may also point to a real issue.
>
I see several uses of the '$<' automatic variable in non-suffix rules.
That use is unportable to non-GNU makes:

  $ cat mk
  all: all2 ; @echo '$$< = $<'
  all2:
  $ /usr/bin/make -f mk
  $< =
  $ gmake -f mk
  $< = all2

I believe the root of the problem lies there.  In fact:

  $ find . -name Makefile | xargs grep sed | grep '[^$]\$[<\*]'
  ...
  ./tp/Makefile:  sed -e 's|address@hidden@]|$(abs_top_srcdir)|' $< > $@

and this seems the culprit: '$<' expands to empty with NetBSD make,
not to the expected 'maintain/catalog.xml'.  If you want to be portable,
and work in VPATH builds with non-GNU makes, you'll have to do something
like this (untested):

    maintain/catalog.xml: maintain/catalog.xml.in Makefile
        $(mkdir_p) maintain
        sed -e 's|address@hidden@]|$(abs_top_srcdir)|' 
<$(srcdir)/address@hidden > $@

And the other uses of '$<' should be fixed as well: they weren't eliciting
visible errors, but probably were silently producing broken output ...

Or you could require GNU make and live happy :-)  Your choice.

>>   And spurious failures in tp/tests, due to an unportable use of mktemp:
> 
> Thanks, this should be fixed in cvs.
>
I will re-test it once the next pre-release tarball is out.

>> Solaris 10
>> ==========
>>
>>   Build succeeds.
>>
>>   At "make check" time, there are some warnings due to the use of the
>>   unportable '-i' sed option in 'tp/tests/many_input_files/tex_l2h.sh'
>>   and 'tp/tests/run_parser_all.sh'.
> 
> Removing -i everywhere is annoying.  Are there really platforms we care
> about that don't have it?
>
All platforms that don't have GNU sed, or that (like this Solaris installation)
have an older GNU sed ...  I say "sed -i" can't be relied upon.

> If so, are there scripts to emulate it?
>
You could write a custom shell function:

  # Usage: sed_i SED-COMMAND FILE
  sed_i ()
  {
     sed "$1" "$2" > t || return 1
     mv -f t "$2"
  }

Or, since the new Texinfo requires perl, you could use '$PERL -i' instead.

>>     gmake[4]: Entering directory 
>> `/scratch/latta/tmp/texinfo-4.13.90/tp/tests/many_input_files'
>>     D: diffs/indices.diff
>>     D: diffs/index_split.diff
>>     FAIL: indices.sh
> 
> Could you please send diffs/indices.diff and diffs/index_split.diff
> files?
>
They are both empty.

and I think the failure is caused by this unportable use of the diff(1)
utility in the test script:

    diff -u --exclude=CVS --exclude=*.png -r ...

In fact:

  $ cat indices.log
  indices
  perl -I ./../.. -I ... --force >> indices.out 2>indices/indices.2
  1> diffs/indices.diff
  diff: illegal option -- exclude=CVS
  usage: diff [-bitw] [-c | -e | -f | -h | -n | -u] file1 file2
         diff [-bitw] [-C number | -U number] file1 file2
         diff [-bitw] [-D string] file1 file2
         diff [-bitw] [-c | -e | -f | -h | -n | -u] [-l] [-r] [-s] [-S name] 
directory1 directory2
  1> diffs/index_split.diff
  diff: illegal option -- exclude=CVS
  usage: diff [-bitw] [-c | -e | -f | -h | -n | -u] file1 file2
         diff [-bitw] [-C number | -U number] file1 file2
         diff [-bitw] [-D string] file1 file2
         diff [-bitw] [-c | -e | -f | -h | -n | -u] [-l] [-r] [-s] [-S name] 
directory1 directory2


> Fedora 16
> =========
>>   D: layout/diffs/formatting_singular.diff
> 
> Could you please send the file too?
>
Here we go:

-*-*-*-

$ cat layout/diffs/formatting_singular.diff
diff -a -u '--exclude=CVS' '--exclude=*.png' '--exclude=*_l2h.css' 
'--exclude=*_1' '--exclude=*_2' -r 
.././layout/res_parser/formatting_singular/formatting.2 
out_parser/formatting_singular/formatting.2
--- .././layout/res_parser/formatting_singular/formatting.2     2012-05-27 
00:27:35.000000000 -0700
+++ out_parser/formatting_singular/formatting.2 2012-11-09 12:25:03.490019609 
-0800
@@ -174,6 +174,12 @@
 formatting.texi:42: @ref reference to nonexistent node `node' (possibly 
involving @mymacro)
 formatting.texi:42: @ref reference to nonexistent node `node' (possibly 
involving @mymacro)
 formatting.texi:42: @ref reference to nonexistent node `node' (possibly 
involving @mymacro)
+defined(%hash) is deprecated at /usr/bin/latex2html line 514.
+       (Maybe you should just omit the defined()?)
+defined(%hash) is deprecated at /usr/bin/latex2html line 2086.
+       (Maybe you should just omit the defined()?)
+defined(%hash) is deprecated at /usr/bin/latex2html line 9087.
+       (Maybe you should just omit the defined()?)
 texexpand
 formatting.texi:18: warning: @image file `f-ile' (for HTML) not found, using 
`f-ile.jpg' (possibly involving @mymacro)
 formatting.texi:18: warning: @image file address@hidden' (for HTML) not found, 
using address@hidden ext e--xt}' (possibly involving @mymacro)
diff -a -u '--exclude=CVS' '--exclude=*.png' '--exclude=*_l2h.css' 
'--exclude=*_1' '--exclude=*_2' -r 
.././layout/res_parser/formatting_singular/index.htm 
out_parser/formatting_singular/index.htm
--- .././layout/res_parser/formatting_singular/index.htm        2012-11-08 
00:26:13.000000000 -0800
+++ out_parser/formatting_singular/index.htm    2012-11-09 12:25:03.550019609 
-0800
@@ -821,10 +821,10 @@
 <code>@math{--a {\frac{1}{2}} @minus{}}</code> <!-- MATH
  $- -a {\frac{1}{2}} @minus{}$
  -->
-<SPAN CLASS="MATH"><IMG
+<IMG
  WIDTH="100" HEIGHT="30" ALIGN="MIDDLE" BORDER="0"
  SRC="sing_2.png"
- ALT="$--a {\frac{1}{2}} @minus{}$"></SPAN>
+ ALT="$--a {\frac{1}{2}} @minus{}$">
 <code>@option{--a}</code> <samp>--a</samp>
 <code>@r{--a}</code> <span class="roman">&ndash;a</span>
 <code>@samp{--a}</code> &lsquo;<samp>--a</samp>&rsquo;
@@ -1294,7 +1294,7 @@

 html ''
 <BR><P></P>
-<DIV ALIGN="CENTER" CLASS="mathdisplay">
+<DIV ALIGN="CENTER">
 <!-- MATH
  \begin{displaymath}
 \partial_t \eta (t) = g(\eta(t),\varphi(t))
@@ -1333,10 +1333,10 @@
 <p><code>@address@hidden {\frac{1}{2}}}</code> <!-- MATH
  $- address@hidden {\frac{1}{2}}$
  -->
-<SPAN CLASS="MATH"><IMG
+<IMG
  WIDTH="100" HEIGHT="30" ALIGN="MIDDLE" BORDER="0"
  SRC="sing_3.png"
- ALT="address@hidden {\frac{1}{2}}$"></SPAN>
+ ALT="address@hidden {\frac{1}{2}}$">
 </p>
 <p><code>@image{f-ile,,,address@hidden:jk _&quot; %}}</code> <img 
src="f-ile.jpg" alt="altjk _&quot; %@">
 <code>@image{f--ile,aze,az,@verb{:jk _&quot; %@:} @b{in b 
&quot;},e--xt}</code> <img src="f--ile.e--xt" alt="jk _&quot; %@ in b &quot;">
@@ -1572,10 +1572,10 @@
 <code>@math{--a {\frac{1}{2}} @minus{}}</code> <!-- MATH
  $- -a {\frac{1}{2}} @minus{}$
  -->
-<SPAN CLASS="MATH"><IMG
+<IMG
  WIDTH="100" HEIGHT="30" ALIGN="MIDDLE" BORDER="0"
  SRC="sing_2.png"
- ALT="$--a {\frac{1}{2}} @minus{}$"></SPAN>
+ ALT="$--a {\frac{1}{2}} @minus{}$">
 <code>@option{--a}</code> <samp>--a</samp>
 <code>@r{--a}</code> <span class="roman">&ndash;a</span>
 <code>@samp{--a}</code> &lsquo;<samp>--a</samp>&rsquo;
@@ -2045,7 +2045,7 @@

 html ''
 <BR><P></P>
-<DIV ALIGN="CENTER" CLASS="mathdisplay">
+<DIV ALIGN="CENTER">
 <!-- MATH
  \begin{displaymath}
 \partial_t \eta (t) = g(\eta(t),\varphi(t))
@@ -2084,10 +2084,10 @@
 <p><code>@address@hidden {\frac{1}{2}}}</code> <!-- MATH
  $- address@hidden {\frac{1}{2}}$
  -->
-<SPAN CLASS="MATH"><IMG
+<IMG
  WIDTH="100" HEIGHT="30" ALIGN="MIDDLE" BORDER="0"
  SRC="sing_3.png"
- ALT="address@hidden {\frac{1}{2}}$"></SPAN>
+ ALT="address@hidden {\frac{1}{2}}$">
 </p>
 <p><code>@image{f-ile,,,address@hidden:jk _&quot; %}}</code> <img 
src="f-ile.jpg" alt="altjk _&quot; %@">
 <code>@image{f--ile,aze,az,@verb{:jk _&quot; %@:} @b{in b 
&quot;},e--xt}</code> <img src="f--ile.e--xt" alt="jk _&quot; %@ in b &quot;">
@@ -2327,10 +2327,10 @@
 <code>@math{--a {\frac{1}{2}} @minus{}}</code> <!-- MATH
  $- -a {\frac{1}{2}} @minus{}$
  -->
-<SPAN CLASS="MATH"><IMG
+<IMG
  WIDTH="100" HEIGHT="30" ALIGN="MIDDLE" BORDER="0"
  SRC="sing_2.png"
- ALT="$--a {\frac{1}{2}} @minus{}$"></SPAN>
+ ALT="$--a {\frac{1}{2}} @minus{}$">
 <code>@option{--a}</code> <samp>--a</samp>
 <code>@r{--a}</code> <span class="roman">&ndash;a</span>
 <code>@samp{--a}</code> &lsquo;<samp>--a</samp>&rsquo;
@@ -2798,7 +2798,7 @@

 html ''
 <BR><P></P>
-<DIV ALIGN="CENTER" CLASS="mathdisplay">
+<DIV ALIGN="CENTER">
 <!-- MATH
  \begin{displaymath}
 \partial_t \eta (t) = g(\eta(t),\varphi(t))
@@ -2837,10 +2837,10 @@
 <code>@address@hidden {\frac{1}{2}}}</code> <!-- MATH
  $- address@hidden {\frac{1}{2}}$
  -->
-<SPAN CLASS="MATH"><IMG
+<IMG
  WIDTH="100" HEIGHT="30" ALIGN="MIDDLE" BORDER="0"
  SRC="sing_3.png"
- ALT="address@hidden {\frac{1}{2}}$"></SPAN>
+ ALT="address@hidden {\frac{1}{2}}$">

 <code>@image{f-ile,,,address@hidden:jk _&quot; %}}</code> [ alt<tt>jk _&quot; 
%@</tt> ]
 <code>@image{f--ile,aze,az,@verb{:jk _&quot; %@:} @b{in b 
&quot;},e--xt}</code> [ <tt>jk _&quot; %@</tt> <b>in b &quot;</b> ]
diff -a -u '--exclude=CVS' '--exclude=*.png' '--exclude=*_l2h.css' 
'--exclude=*_1' '--exclude=*_2' -r 
.././layout/res_parser/formatting_singular/sing-l2h_cache.pm 
out_parser/formatting_singular/sing-l2h_cache.pm
--- .././layout/res_parser/formatting_singular/sing-l2h_cache.pm        
2012-01-14 11:04:07.000000000 -0800
+++ out_parser/formatting_singular/sing-l2h_cache.pm    2012-11-09 
12:25:03.620019609 -0800
@@ -3,14 +3,14 @@
 $l2h_cache{$l2h_cache_key} = q|<!-- MATH
  $- address@hidden {\frac{1}{2}}$
  -->
-<SPAN CLASS="MATH"><IMG
+<IMG
  WIDTH="100" HEIGHT="30" ALIGN="MIDDLE" BORDER="0"
  SRC="sing_3.png"
- ALT="address@hidden {\frac{1}{2}}$"></SPAN>|;
+ ALT="address@hidden {\frac{1}{2}}$">|;

 $l2h_cache_key = q/$$\partial_t \eta (t) = g(\eta(t),\varphi(t))$$ ''/;
 $l2h_cache{$l2h_cache_key} = q|<BR><P></P>
-<DIV ALIGN="CENTER" CLASS="mathdisplay">
+<DIV ALIGN="CENTER">
 <!-- MATH
  \begin{displaymath}
 \partial_t \eta (t) = g(\eta(t),\varphi(t))
@@ -29,8 +29,8 @@
 $l2h_cache{$l2h_cache_key} = q|<!-- MATH
  $- -a {\frac{1}{2}} @minus{}$
  -->
-<SPAN CLASS="MATH"><IMG
+<IMG
  WIDTH="100" HEIGHT="30" ALIGN="MIDDLE" BORDER="0"
  SRC="sing_2.png"
- ALT="$--a {\frac{1}{2}} @minus{}$"></SPAN>|;
+ ALT="$--a {\frac{1}{2}} @minus{}$">|;
 1;
\ No newline at end of file
diff -a -u '--exclude=CVS' '--exclude=*.png' '--exclude=*_l2h.css' 
'--exclude=*_1' '--exclude=*_2' -r 
.././layout/res_parser/formatting_singular/sing_l2h.html 
out_parser/formatting_singular/sing_l2h.html
--- .././layout/res_parser/formatting_singular/sing_l2h.html    2012-01-14 
11:04:07.000000000 -0800
+++ out_parser/formatting_singular/sing_l2h.html        2012-11-09 
12:25:03.580019609 -0800
@@ -1,4 +1,4 @@
-<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">

 <!--Converted with LaTeX2HTML
 original version by:  Nikos Drakos, CBLU, University of Leeds
@@ -24,7 +24,7 @@

 <!-- l2h_begin sing_l2h 1 -->
 <BR><P></P>
-<DIV ALIGN="CENTER" CLASS="mathdisplay">
+<DIV ALIGN="CENTER">
 <!-- MATH
  \begin{displaymath}
 \partial_t \eta (t) = g(\eta(t),\varphi(t))
@@ -45,10 +45,10 @@
 <!-- MATH
  $- -a {\frac{1}{2}} @minus{}$
  -->
-<SPAN CLASS="MATH"><IMG
+<IMG
  WIDTH="100" HEIGHT="30" ALIGN="MIDDLE" BORDER="0"
  SRC="sing_l2h_img2.png"
- ALT="$--a {\frac{1}{2}} @minus{}$"></SPAN>
+ ALT="$--a {\frac{1}{2}} @minus{}$">

 <!-- l2h_end sing_l2h 2 -->

@@ -56,10 +56,10 @@
 <!-- MATH
  $- address@hidden {\frac{1}{2}}$
  -->
-<SPAN CLASS="MATH"><IMG
+<IMG
  WIDTH="100" HEIGHT="30" ALIGN="MIDDLE" BORDER="0"
  SRC="sing_l2h_img3.png"
- ALT="address@hidden {\frac{1}{2}}$"></SPAN>
+ ALT="address@hidden {\frac{1}{2}}$">

 <!-- l2h_end sing_l2h 3 -->
 <BR>

-*-*-*-

Regards,
  Stefano
reply via email to
[Prev in Thread] Current Thread [Next in Thread]