texinfo-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[8316] parsetexi change some FIXME to TODO


From: gavinsmith0123
Subject: [8316] parsetexi change some FIXME to TODO
Date: Wed, 17 Oct 2018 10:52:53 -0400 (EDT)

Revision: 8316
          http://svn.sv.gnu.org/viewvc/?view=rev&root=texinfo&revision=8316
Author:   gavin
Date:     2018-10-17 10:52:53 -0400 (Wed, 17 Oct 2018)
Log Message:
-----------
parsetexi change some FIXME to TODO

Modified Paths:
--------------
    trunk/tp/Texinfo/XS/parsetexi/api.c
    trunk/tp/Texinfo/XS/parsetexi/close.c
    trunk/tp/Texinfo/XS/parsetexi/end_line.c
    trunk/tp/Texinfo/XS/parsetexi/macro.c

Modified: trunk/tp/Texinfo/XS/parsetexi/api.c
===================================================================
--- trunk/tp/Texinfo/XS/parsetexi/api.c 2018-10-17 14:38:14 UTC (rev 8315)
+++ trunk/tp/Texinfo/XS/parsetexi/api.c 2018-10-17 14:52:53 UTC (rev 8316)
@@ -210,7 +210,7 @@
       sv = newRV_inc ((SV *) e->parent->hv);
       hv_store (e->hv, "parent", strlen ("parent"), sv, 0);
     }
-  /* FIXME: this assumes we don't have nested out-of-tree subtrees,
+  /* This assumes we don't have nested out-of-tree subtrees,
      i.e. the only out-of-tree elements are simple text elements
      (or other elements with no children) - otherwise we shall fail
      to set "parent" properly. */
@@ -231,7 +231,7 @@
       /* TODO: Same optimizations as for 'type'. */
     }
 
-  /* FIXME sort out all these special cases */
+  /* TODO sort out all these special cases */
   if (e->contents.number > 0
       || e->type == ET_text_root
       || e->type == ET_root_line
@@ -262,8 +262,8 @@
               || command_data(e->cmd).data == BRACE_other
               || command_data(e->cmd).data == BRACE_accent
               ))
-      || e->cmd == CM_node) // FIXME special case
-    // FIXME: Makes no sense to have 'contents' created for glyph commands like
+      || e->cmd == CM_node) // TODO special case
+    // TODO: Makes no sense to have 'contents' created for glyph commands like
     // @arrow{} or for accent commands.
     {
       AV *av;
@@ -305,8 +305,8 @@
         hv_store (e->hv, "type", strlen ("type"), sv, 0);
 
       SvUTF8_on (sv);
-      /* FIXME: Check that the strings we have are in UTF-8 to start with.
-         This would lead to an unnecessary round trip with "@documentencoding 
+      /* The strings here have to be in UTF-8 to start with.
+         This leads to an unnecessary round trip with "@documentencoding 
          ISO-8859-1" for Info and plain text output, when we first convert the 
          characters in the input file to UTF-8, and convert them back again 
for 
          the output.

Modified: trunk/tp/Texinfo/XS/parsetexi/close.c
===================================================================
--- trunk/tp/Texinfo/XS/parsetexi/close.c       2018-10-17 14:38:14 UTC (rev 
8315)
+++ trunk/tp/Texinfo/XS/parsetexi/close.c       2018-10-17 14:52:53 UTC (rev 
8316)
@@ -282,8 +282,7 @@
                   parent = current->parent;
                   destroy_element (pop_element_from_contents (parent));
                 }
-              /* FIXME: Why not avoid adding the element
-                 in the first place? */
+              /* TODO: Maybe avoid adding the element in the first place. */
             }
           if (command_data(cmd).flags
               & (CF_preformatted | CF_menu | CF_format_raw))

Modified: trunk/tp/Texinfo/XS/parsetexi/end_line.c
===================================================================
--- trunk/tp/Texinfo/XS/parsetexi/end_line.c    2018-10-17 14:38:14 UTC (rev 
8315)
+++ trunk/tp/Texinfo/XS/parsetexi/end_line.c    2018-10-17 14:52:53 UTC (rev 
8316)
@@ -455,9 +455,6 @@
             if (!is_decimal_number (arg))
               {
                 line_error ("column fraction not a number: %s", arg);
-
-                /* FIXME: Possible bug in the Perl version - it accepts
-                   2x.2, 2.23x */
               }
             else
               {

Modified: trunk/tp/Texinfo/XS/parsetexi/macro.c
===================================================================
--- trunk/tp/Texinfo/XS/parsetexi/macro.c       2018-10-17 14:38:14 UTC (rev 
8315)
+++ trunk/tp/Texinfo/XS/parsetexi/macro.c       2018-10-17 14:52:53 UTC (rev 
8316)
@@ -87,7 +87,7 @@
   macro->line_nr = line_nr;
 
   add_extra_string (macro, "arg_line", strdup (line));
-  /* FIXME: This extra value isn't used much, so is a candidate for
+  /* TODO: This extra value isn't used much, so is a candidate for
      simplification. */
 
   line += strspn (line, whitespace_chars);




reply via email to

[Prev in Thread] Current Thread [Next in Thread]