Re: [Texi2html-bug] All lists get a class="toc" and thus no bullets...

[Reinhold Kainhofer]

Am Montag, 17. März 2008 schrieb Patrice Dumas:
> On Sun, Mar 16, 2008 at 09:56:56PM +0100, Reinhold Kainhofer wrote:
> > Hi,
> >
> > In lilypond's documentation we use some unordered list, but
> > unfortunately, *all* lists are formatted as <ul class="toc">, which makes
> > them appear without a bullet. An example is:
>
> I have commited a fix. Thanks for the report.

Thanks!
Did you maybe forget a "my" in Line 2856 of texi2html.init?
    $hash = \%things_map
causes an error (the usual "Global symbol "$hash" requires explicit package 
name" indicating a missing my).

After inserting "my", everything works just fine. Thanks for the quick fix!

Another issue: If i call texi2html with --lang=de, it will always crash, 
because in line 589 of texi2html.pl, the $style->{'args'} is not defined and 
should not be used as an array ref. 

Attached is a patch to fix both issues (inserting 'my' and adding a check for 
an array ref).

> > So, should this really insert TOC_LIST_ATTRIBUTE? If yes, how can I make
> > bullets appear in non-TOC lists?
>
> In fact TOC_LIST_ATTRIBUTE is badly named. It is the ul attribute used
> when there is no bullet, it first appeared in table of contents.
> NO_BULLET_LIST_ATTRIBUTE is not much better, so I think I'll leave it as
> is.

I think NO_BULLET_LIST_ATTRIBUTE is much better, because it does not indicate 
that it has anything to do with content (i.e. a clearer separation between 
content and markup).

Cheers,
Reinhold
-- 
------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/

2008-03-17_Fix_Crashes_Lang.patch
Description: Text Data