[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [sysvinit-devel] [PATCH 4/5] init.c: change parameter in test functi
Re: [sysvinit-devel] [PATCH 4/5] init.c: change parameter in test function - redo_utmp_wtmp()
Mon, 10 Feb 2014 23:51:13 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0
W dniu 10.02.2014 22:01, Petter Reinholdtsen pisze:
Simple fix in redo_utmp_wtmp() function:
in test function currently is check the same value:
if ((wrote_wtmp_rlevel == 0) || (wrote_*wtmp*_rlevel == 0))
if ((wrote_wtmp_rlevel == 0) || (wrote_*utmp*_rlevel == 0))
Did you figure out what the point of checking wrote_utmp_rlevel is?
It seem like a no-brainer, but I did not dare to do this change myself
without understanding why the code was like it was and exactly what it
did. Can you explain?
OK, I'll review it again tomorrow and explaint it.
Actually, I could made a mistake here.