[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Swftools-common] Small bug in swfcombine.c (incl. patch)
From: |
Oliver Smith |
Subject: |
Re: [Swftools-common] Small bug in swfcombine.c (incl. patch) |
Date: |
Thu, 5 Aug 2010 18:39:24 +0100 |
On 5 Aug 2010, at 17:48, Matthias Kramm wrote:
> On Wed, Aug 04, 2010 at 02:33:11PM +0100, Oliver Smith <address@hidden> wrote:
>> First off, thanks to the developers of swftools for such a useful set of
>> utilities!
>>
>> I've found a small bug in swfcombine.c -- it's not correctly checking the
>> return value from open(), so
>> occasionally it will complain that it's unable to open a file, even if it's
>> successfully opened it.
>>
>> Patch for the fix below. This was a real head-scratcher to track down.
>> Hope it's useful!
>
> Thanks! I'll apply this.
>
> Btw. what kind of operating system do you have that occasionally assigns to
> the
> zero file descriptor?
>
> Matthias
Believe it or not... Linux!
We're calling swfcombine from a Python script that automates a bunch of
document conversion and I _think_ the Python subprocess library does
interesting stuff with stdin/stdout/stderr, hence the slightly unusual
availability of the zero file descriptor.
Olly