stumpwm-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [STUMP] Re: head-resizing facility


From: Vitaly Mayatskikh
Subject: Re: [STUMP] Re: head-resizing facility
Date: Wed, 11 Nov 2009 15:03:14 +0100
User-agent: Wanderlust/2.15.6 (Almost Unreal) Emacs/23.1 Mule/6.0 (HANACHIRUSATO)

At Wed, 11 Nov 2009 13:30:38 +0000, Ben Spencer wrote:
 
> On Tue, Nov 10, 2009 at 10:23:26PM +0100, Vitaly Mayatskikh wrote:
> > Ben fixed 'The value NIL is not of type STUMPWM::HEAD.' error in
> > function resize-tree, but the logic of resize-tree is incorrect for
> > head resizing. You can see it by applying only 2 hunks (w/o renewed
> > resize-tree), splitting head and resizing it. Renewed resize-tree
> > seems to work.
> 
> I see the problem - my implementation calls tree-x and tree-y within
> the loop, which means they'll get the new value after the first frame
> has been moved.  Your patch is correct (but xo and yo are unnecessary
> because x and y are already given default values in the argument list,
> and 0 would be the wrong default value anyway).

Yep, perhaps. So, would you like to fix resize-tree? :)
-- 
wbr, Vitaly




reply via email to

[Prev in Thread] Current Thread [Next in Thread]