[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [STUMP] [PATCH] Enable resizing float group windows

From: Lionel Flandrin
Subject: Re: [STUMP] [PATCH] Enable resizing float group windows
Date: Fri, 23 Oct 2009 15:13:03 +0200
User-agent: Mutt/1.5.20 (2009-06-14)

On Fri, Oct 23, 2009 at 01:42:40PM +0100, Ben Spencer wrote:
> On Thu, Oct 22, 2009 at 10:48:36PM +0200, Lionel Flandrin wrote:
> > I've merged Raffael's modifications "by hand". The resulting patch
> > seems to work as intended, I haven't tested it in detail tho.
> Thanks for that.  I found that the patch was removing a couple of
> chunks of the existing code: attached is a (hopefully) fixed version.
> I'm personally happy with the change itself so unless anyone objects
> I'll commit the patch in this form.
> > By the way, this "group-button-press" method is getting huge, I think
> > it could use some refactoring.
> Agreed.
> > I've kept Raffael as commiter for the patch so I won't get the credit
> > by mistake, I hope he won't mind.
> Ditto.
> Ben

 There is an other issue as well: nothing's easily configurable. One
should at least be able to set which mouse button to use for
resizing/moving windows. Also I think one should be able to do that
with the keyboard as well, even in float mode. After all, this used to
be a keyboard-driven manager :).

 Maybe the patch should be committed anyway so people will be able to
play with it and improve it, but we should "fix" that for the next
release/milestone. We should keep track of stuff like that a bit in
the way trac does its roadmaps[1]. I don't know if we can do that with
savannah but I guess there must be something like that. Code rot must
be avoided at all costs, especially now we opted for a more
distributed development process.


Lionel Flandrin

Attachment: pgp6BnBroqahx.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]