sks-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Lying about Hockeypuck being SKS?


From: Marcel Waldvogel
Subject: Re: Lying about Hockeypuck being SKS?
Date: Tue, 23 Mar 2021 10:19:38 +0100
User-agent: Evolution 3.38.1-1

pgpkeys.eu is in the pool, however, the "Software" table cell is red. Further investigation showed that they spell "sks" in lower case, unlike the real SKS.

Verifying against the source code [1], the server selection code is a blacklist: "SKS" < 1.1.6, "GnuKS", and "hockeypuck" are blacklisted (case-sensitive).

How about instead of claiming to be "SKS", Hockeypuck servers just claim to be "Hockeypuck" (title case instead of lower case)? That would be kind of a "white(list) lie". They will have a red cell, but that will not preclude their

I have changed my Hockeypucks to return this version and will check in 30 minutes whether the theory can be corroborated.

Happy keyserving,
-Marcel

[1] https://git.sumptuouscapital.com/?p=sks-keyservers-pool.git;a=blob;f=sks-keyservers.net/status-srv/sks-status.inc.php;h=972bb5b56412ae54b8aade234ea02bb8c9545d45;hb=HEAD#l309

On Mon, 2021-03-22 at 21:13 +0100, Andreas Puls wrote:


Am 22.03.2021 um 20:41 schrieb Marcel Waldvogel:
On Sun, 2021-03-21 at 22:56 +0100, Andreas Puls wrote:

I've created now a patch that just replaces in the json export
contact
with server_contact and Total with numkeys.
https://github.com/apuls/hockeypuck/commit/34fbdfcf73b60e6001f3770b86d8750d1c8b5385

Great, thanks! I just merged this. Now my Hockeypuck server appears in
the statistics.

You're welcome!

In my hockeypuck configuration i've set Version to 1.1.6+ and
Software
to SKS

Yeah, i've done it too. :)

Hockeypuck is blacklisted in the sks-keyservers.net code, because it
was not good enough to be incorporated into the pool when Kristian
wrote the code. Now, it seems to be in the same ballpark as SKS.

Asking Kristian to remove the Hockeypuck ban resulted in him explaining
that he does not plan to change the code or accept changes; instead, we
should set up our own fork of his code.

I think this leaves us with the following ways to progress:

a) We leave it as is, Hockeypuck is fine, but just not in the pool.
b) We create a second pool, where Hockeypuck is acceptable (and
probably SKS as well).
c) We agree that Hockeypuck lying to be SKS is accepted in the pool,
and maybe even recommended.

I would favor (c), plus keeping the version number in the 2.x range, so
that experts still can tell the difference.

b would be great but i think this is a hell of work.

Since we haven't heard for a while from Kristian and the pool is working
- ok more or less - i would go with option c too. Also with the Version
string 2.x .
Opinions?
We need to fix the peers field which will be reported via options=mr to
meet the requirements from the pool skript.

-Marcel
Br
   Andreas


reply via email to

[Prev in Thread] Current Thread [Next in Thread]