skribilo-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/3] Add CommonMark reader


From: Ludovic Courtès
Subject: Re: [PATCH 0/3] Add CommonMark reader
Date: Wed, 21 Feb 2024 16:29:06 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

Hello!

Arun Isaac <arunisaac@systemreboot.net> skribis:

> Thank you for the patches! I trust you got them right. Please push. Just
> a couple of quick concerns, though:
>
>> Ludovic Courtès (3):
>>   guix: Explicitly list all the inputs.
>
> Why the explicit listing of inputs? It seems less redundant to inherit
> from the upstream Guix package

I thought the two might diverge, as in this case: we need Autotools and
guile-commonmark, so I find it somewhat clearer to be explicit about
what we expect.

>> * src/guile/skribilo/reader/commonmark.scm,
>> tests/readers/commonmark.test: New files.
>> * configure.ac: Check for (commonmark) ans define ‘BUILD_COMMONMARK_READER’.
>> * src/guile/Makefile.am (readers, EXTRA_DIST): Add ‘commonmark.scm’.
>> * doc/user/syntax.skb (The CommonMark Syntax): New section.
>> (The Outline Syntax): Adjust initial sentence.
>> * .guix/skribilo-package.scm (skribilo)[propagated-inputs]: Add
>> GUILE-COMMONMARK.
>> (skribilo/guile-2.0): Remove GUILE-COMMONMARK from ‘propagated-inputs’.
>
> Maybe, it is better to not capitalize GUILE-COMMONMARK.

Indeed, it’s less aggressive.

Pushed as 76d411844466c9248c929452d6991298d110b945!

Looks like there’s material for a new release, with the two new readers.

BTW, I figured the fact that readers emit code as sexps is pretty bad:
it’s an additional layer that makes things more brittle and less
efficient, because we need to pass that sexp through ‘eval’, and there
could well be undefined variables and the likes.  It would be more
natural for readers to return a <document> object.

I’m throwing the idea in case Someone wants to look into it…

Thanks for your feedback!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]