skribilo-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/3] Add CommonMark reader


From: Arun Isaac
Subject: Re: [PATCH 0/3] Add CommonMark reader
Date: Mon, 19 Feb 2024 15:48:22 +0000

Hi Ludo,

Thank you for the patches! I trust you got them right. Please push. Just
a couple of quick concerns, though:

> Ludovic Courtès (3):
>   guix: Explicitly list all the inputs.

Why the explicit listing of inputs? It seems less redundant to inherit
from the upstream Guix package

> * src/guile/skribilo/reader/commonmark.scm,
> tests/readers/commonmark.test: New files.
> * configure.ac: Check for (commonmark) ans define ‘BUILD_COMMONMARK_READER’.
> * src/guile/Makefile.am (readers, EXTRA_DIST): Add ‘commonmark.scm’.
> * doc/user/syntax.skb (The CommonMark Syntax): New section.
> (The Outline Syntax): Adjust initial sentence.
> * .guix/skribilo-package.scm (skribilo)[propagated-inputs]: Add
> GUILE-COMMONMARK.
> (skribilo/guile-2.0): Remove GUILE-COMMONMARK from ‘propagated-inputs’.

Maybe, it is better to not capitalize GUILE-COMMONMARK.

All good otherwise.

Thanks again!
Arun



reply via email to

[Prev in Thread] Current Thread [Next in Thread]