Re: [Simulavr-devel] some patches committed

[Joel Sherrill]

Onno Kortmann wrote:
> Hi Joel,
> Am Freitag, 22. Mai 2009 16:39 schrieb Joel Sherrill:
>   
> > Onno.. examples/feedback is not running for me
> > with these changes in.  Please let me know
> > what I missed committing.
> >     
> I'll have a look.
Thanks.  I just tried with this:

diff -u -D yesterday avrdevice* hwmegatimer.cpp hwmegax8timer.cpp 
hwtimer.cpp | patch -p0 -R

and examples/feedback runs.  So something
broke with this patch.

FYI I had to apply some of it by hand so
please double check that it isn't just
a mistake on my part.

>  I just found that there is a strange change
> in atmega128.cpp:
>
> diff --git a/src/atmega128.cpp b/src/atmega128.cpp
> index 80c838f..9619944 100644
> --- a/src/atmega128.cpp
> +++ b/src/atmega128.cpp
> @@ -40,7 +40,7 @@
>  //#include "avrdevice_impl.h"
>  AvrDevice_atmega128::~AvrDevice_atmega128() {}
>  AvrDevice_atmega128::AvrDevice_atmega128():
> -AvrDevice(224, 4096, 0xef00, 128*1024),
> +AvrDevice(224, 4096, 0xef00, 256*1024),
>  aref()
>  {
>
> As far as I can see, this was not in my patch. Maybe 
> this is some test code which slipped in?
>
>   
Yes.  Sorry.  avrtest provides 256K  and I had
locally modified it to match.  Isn't 256K the
architectural limit?  Would it be OK to leave this
in?

We really need a way to specify the memory size.
But that's a different project.
> Best regards,
>
> Onno
>   


--
Joel Sherrill, Ph.D.             Director of Research & Development
address@hidden        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
  Support Available             (256) 722-9985