Re: [platform-testers] new snapshot available: sed-4.3.20-e9ab

[Eric Blake]

On 02/01/2017 04:29 PM, Jim Meyering wrote:
> On Wed, Feb 1, 2017 at 11:51 AM, Eric Blake <address@hidden> wrote:
>> sed.git fails to compile on Cygwin:
>>
>> sed/compile.c: In function 'savchar':
>> sed/compile.c:259:15: error: format '%x' expects argument of type
>> 'unsigned int', but argument 2 has type 'int' [-Werror=format=]
>>          panic("Called savchar() with unexpected pushack (%x)",
>>                ^

The mismatch in types may be worth silencing,

>> sed/compile.c: In function 'bad_prog':
>> sed/compile.c:210:1: error: function might be candidate for attribute
>> 'noreturn' [-Werror=suggest-attribute=noreturn]
>>  bad_prog(const char *why)
>>  ^
> 
> Hi Eric,
> Thank you for the testing and report. At least that second
> warning/error is misleading because the bad_prog function is already
> declared with _Noreturn:
> 
>   sed/sed.h:_Noreturn void bad_prog (const char *why);

but I have no idea why the _Noreturn designation isn't working. I wonder
if a gnulib probe is going wrong, leading to some unwanted #defines
here.  I'll try and investigate.

> 
> I suggest that you avoid configuring with `--enable-gcc-warnings` on cygwin.

Indeed, the snapshot does just that (and I should have been testing the
snapshot instead of git, even though they are built from the same
point).  Still, I'll see if I can spend time preparing a patch for any
any obvious cleanups that silence some warnings.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature