Re: Patch for sed-4.2.2.177-a348 on mingw-w64

[Jim Meyering]

On Tue, Dec 13, 2016 at 9:43 PM, Stephan T. Lavavej <address@hidden> wrote:
> Hi,
>
> I build sed as part of my mingw-w64 distro. When I saw the
> sed-4.2.2.177-a348 snapshot, I eagerly tried it, but it catastrophically
> failed to compile (see [1] for the errors). Miodrag Milanovic figured out
> that the following one-line patch is necessary:
>
>
> diff -aurN sed-4.2.2.177-a348/Makefile.in
> sed-4.2.2.177-a348-fixed/Makefile.in
> --- sed-4.2.2.177-a348/Makefile.in      2016-12-05 15:24:27.000000000 -0800
> +++ sed-4.2.2.177-a348-fixed/Makefile.in        2016-12-13
> 21:04:52.016792000 -0800
> @@ -5776,7 +5776,7 @@
>         fi
>         echo stamp > $(srcdir)/doc/s-texi
>
> -doc/sed.1: sed/sed .version $(srcdir)/doc/sed.x
> +doc/sed.1: sed/sed$(EXEEXT) .version $(srcdir)/doc/sed.x
>         $(AM_V_GEN)$(MKDIR_P) doc
>         $(AM_V_at)rm -rf $@ address@hidden
>         $(AM_V_at)$(HELP2MAN)                                           \
>
>
> With this, the snapshot builds flawlessly for mingw-w64 (and runs fine,
> according to 5 seconds of cursory testing). (While I understand what the
> patch is doing - MinGW has executable extensions while ordinary Unix doesn't
> - I have no clue how this ended up completely wrecking the build.)
>
> Could you please incorporate this patch into the upcoming release? Thank you
> for your continuing work - I'm looking forward to the new release.

Thank you for the testing and the patch.
I will push the attached shortly:

sed-doc-mingw-fix.diff
Description: Text document