Re: build failure with 'make distcheck' without 'make' first

[Jim Meyering]

On Sat, Dec 10, 2016 at 10:00 PM, Assaf Gordon <address@hidden> wrote:
> Hello,
>
> I noticed something strange, the following fails to build:
>
>     $ make distclean ; ./configure ; make distcheck
>     [...]
>        CC       sed/sed_sed-compile.o
>     In file included from sed/compile.c:20:
>     In file included from ./sed/sed.h:26:
>     ./sed/utils.h:30:45: error: expected function body after function 
> declarator
>     _Noreturn void panic (const char *str, ...) _GL_ATTRIBUTE_FORMAT_PRINTF 
> (1, 2);
>                                                 ^
>     ./sed/utils.h:42:38: error: expected function body after function 
> declarator
>                        const char *mode) _GL_ARG_NONNULL ((1, 2, 3, 4));
>                                      ^
>     sed/compile.c:259:9: warning: implicit declaration of function 'panic' is 
> invalid in C99 [-Wimplicit-function-declaration]
>             panic("Called savchar() with unexpected pushback (%x)",
>             ^
>     sed/compile.c:1088:17: warning: implicit declaration of function 
> 'strverscmp' is invalid in C99
>           [-Wimplicit-function-declaration]
>                 if (strverscmp (compared_version, PACKAGE_VERSION) > 0)
>                     ^
>     2 warnings and 2 errors generated.
>     make[1]: *** [sed/sed_sed-compile.o] Error 1
>     make: *** [dist] Error 2
>
>
> >From a cursory look it seems building 'gnulib' is not a dependency of 
> >'distcheck'.
>
> I'll investigate further tomorrow.

Thanks for reporting that.
I've fixed it with the attached:

sed-make-dist-vs-missing-dep.diff
Description: Text document