sed-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 6 small maintenance patches


From: Jim Meyering
Subject: Re: 6 small maintenance patches
Date: Mon, 25 Jul 2016 22:41:56 -0700

On Mon, Jul 25, 2016 at 9:25 PM, Assaf Gordon <address@hidden> wrote:
> Hello,
>
> Attached 6 small maintenance patches (including the 2 for THANKS.in).
>
> Comments welcomed,
>  - assaf
>
>
> Assaf Gordon (4):
>   maint: update .gitignore
>   maint: update .gitignore after bootstrap
>   maint: add copyright/license information to configure.ac
>   maint: add static-analysis target to cfg.mk
>
> Jim Meyering (2):
>   maint: sort THANKS.in
>   maint: skip a check when en_US.UTF-8 collation rules are broken
>
>  .gitignore           |  9 +++++++++
>  THANKS.in            |  2 +-
>  build-aux/.gitignore |  2 ++
>  cfg.mk               | 46 ++++++++++++++++++++++++++++++++++++++--------
>  configure.ac         | 15 +++++++++++++++
>  lib/.gitignore       |  3 +++
>  m4/.gitignore        | 33 +++++++++++++++++++++++++++++++++
>  po/.gitignore        |  9 +++++++++
>  8 files changed, 110 insertions(+), 9 deletions(-)

Thanks.
I've just pushed the first two.
Your patches look fine, modulo one style nit in two rules of your
Makefile.am change:

+static-analysis-init:
+    type scan-build 1>/dev/null 2>&1 || \
+        { echo "scan-build program not found" >&2 ; exit 1 ;}

Just as in C code, in bourne shell  scripts, I prefer to leave space
after the semicolon, not before it.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]