[screen-devel] [bug #38567] [PATCH] exec: fix ':' for stdin

[Stas Sergeev]

URL:
  <http://savannah.gnu.org/bugs/?38567>

                 Summary: [PATCH] exec: fix ':' for stdin
                 Project: GNU Screen
            Submitted by: stsp
            Submitted on: Птн 22 Мар 2013 11:02:30
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
                 Release: None
           Fixed Release: None
         Planned Release: None
           Work Required: None

    _______________________________________________________

Details:

Hi.

I've found out that ':' for stdin in an exec pattern doesn't
work. The reason is that if '!' is used for stdin, then the
w_pty fd is just duped to the sub process, so that the p_pty
is bypassed. But with ':' there is a relay mechanism via the
p_pty. In order to match the behaviour of the bypassed pty,
the pty must be set to raw mode, which is what the attached
patch does.
Without the attached patch, if the relayed data does not contain
the '\n's, the sub-process will simply receive nothing at all, because
the pty is then line-buffered.

Does the patch look good?



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Птн 22 Мар 2013 11:02:30  Name: 0001-exec-fix-for-stdin.patch 
Size: 815B   By: stsp

<http://savannah.gnu.org/bugs/download.php?file_id=27651>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?38567>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/