savannah-hackers-public
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Savannah-hackers-public] Final-stage work/changes on adding the Git


From: Ineiev
Subject: Re: [Savannah-hackers-public] Final-stage work/changes on adding the Git homepage source code web browsing option.
Date: Wed, 17 Jan 2024 19:26:27 +0000

On Tue, Jan 16, 2024 at 09:55:37PM -0500, Ian Kelling wrote:
> > Still it will be single repository at the same time, and in fact,
> > non-default values are (and will be) effectively never used.
> 
> What do you mean by "single repository at the same time"?

I mean that Savannah isn't supposed to simultaneously display
multiple home pages, each originating from the respective VCS.
The home page at any specific moment will reflect a single choice.

Of course, Savannah is expected to support working with all
repositories that have ever been created, even when disabled,
like it does now, and has always done.

> > There is no need for this new field, and for any other new fields,
> > on the other hand, the harm would be more than palpable.
> 
> Well, I can think of ways to reuse existing fields in new ways, or
> compute information without using a field, but this seems to follow the
> existing pattern in the code base: clearly fields were added when git
> support was added for non-web repositories.

That wasn't a very good decision. generally, the existing
patterns in the code base are often far from perfect.

> What is the harm you see?

The new code wouldn't work with old databases; all existing
instances and dumps would need manual error-prone updating.
the SQL queries would fetch excessive data that isn't needed
in most cases. the column list grows boundless.

> Do you suggest alternatives?

Yes.  I'll send the details a few hours later.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]