Re: [rdiff-backup-users] Error with accented character

[Andrew Ferguson]

SOULfly_B wrote:
> It seems this issue is not fixed cause I still have the problem.
> 
> Attached is an extract of the traceback.

Hi Bruno,

You have picked up a very interesting bug, which was introduced in
1.1.8. When you first sent your report, I had only looked at the changes
I had made.

For the curious, it comes from this change:
http://cvs.savannah.gnu.org/viewvc/rdiff-backup/rdiff_backup/fs_abilities.py?root=rdiff-backup&r1=1.30&r2=1.31
and this email:
http://lists.nongnu.org/archive/html/rdiff-backup-users/2007-01/msg00096.html

What that change did was skewer the extended_filenames test.

>From what I gather, Marc noticed that characters in the range 128-255
are valid on FAT32 and were being escaped by rdiff-backup, so he changed
the regex.

However, the regex was right for some situations, and it was what made
rdiff-backup work for you, Bruno.

The reason rdiff-backup was escaping valid characters in Marc's setup
was because the extended_filenames test was too general. It attempts to
create a file named ": \ 0xE1 0x84 0x89" (without the spaces). The test
failed for Marc because : and \ are illegal in FAT32 filenames. It fails
for you because the Unicode characters are illegal in your SMB setup.

The regex we just talked about was redesigned to deal with the : and \,
and ignored the fact that the test can fail because of the Unicode
characters.

I don't have a fix for you yet since it will take some time to split out
the code and remove this bug properly. But stay tuned, and rest assured
that it will not be there in 1.1.15 and 1.2.0. :-)

Thank you so much,
Andrew

-- 
Andrew Ferguson - address@hidden