[rdiff-backup-users] rdiff-backup turning directory into file on restore

[devzero]

Hello !

i did try to restore a single file the following way:

rdiff-backup -r 2D -v9 ./rdiff-backup-repo/path/file /tmp/restore

and it looks like this:

Sat May 13 14:49:16 2006  Starting restore of rdiff-backup-repo/path/file  to 
/tmp/restore as it was as of Thu May 11 14:49:16 2006.
Sat May 13 14:49:24 2006  Processing changed file .
Sat May 13 14:49:24 2006  Regular copying () to /tmp/rdiff-backup.tmp.1
Sat May 13 14:49:24 2006  Writing file object to /tmp/rdiff-backup.tmp.1
Sat May 13 14:49:24 2006  Copying attributes from () to /tmp/rdiff-backup.tmp.1
Sat May 13 14:49:24 2006  Setting time of /tmp/rdiff-backup.tmp.1 to 1144103268
Sat May 13 14:49:24 2006  Removing directory /tmp/restore                       
                <-- !?!?!
Sat May 13 14:49:24 2006  Renaming /tmp/rdiff-backup.tmp.1 to /tmp/restore
Sat May 13 14:49:24 2006  Restore finished
Sat May 13 14:49:24 2006  Cleaning up

after this, silently and without a notice (when leaving out -v9), rdiff-backup 
has turned /tmp/restore from a directory into a file - the restored one.

i searched this list and found some references about users who seem to have 
lost some data on restore (can provide a list of links if you like). i also did 
a posting that i killed my whole rdiff-repository because i probably used 
"--force" a little bit too uncautiously.

the "Removing directory /tmp/restore" in the debug output really looks somewhat 
problematic for me and this _may_ be an underestimated issue. 
rdiff-backup (and any other backup utility) shouldn`t do this on restore, imho. 
(it`s like if i did "cp /etc/hosts /tmp" and then /tmp being turned into a file 
after this)

i think dealing with this a little bit more securely could prevent some user 
errors.

comments ?

regards
roland
_______________________________________________________________
SMS schreiben mit WEB.DE FreeMail - einfach, schnell und
kostenguenstig. Jetzt gleich testen! http://f.web.de/?mc=021192