Re: [rdiff-backup-users] compare: ignore ctime

[Ben Escoto]

>>>>> "Carsten Lorenz" <address@hidden>
>>>>> wrote the following on Mon, 28 Nov 2005 18:59:47 +0100
> Some test later ...
> There is something wrong with the acls.
> 
> With --no-acls it took only 1.5 hours to process 1.17 TB !
> Of cause it depends how many files change, but our last full tape-backup
> lasts more than 2.5 days.
> 
> I have found a test case where rdiff-backup detects every file as
> changed although the files are unchanged.
> If i add the option --no-acls all works fine!

Yes, there's a bug.  I don't think any data could be lost because of
it, but some files with ACLs will be considered changed when they
weren't, leading to the bad performance you noticed.

This patch should fix the problem:


diff -u -r1.16 eas_acls.py
--- rdiff_backup/eas_acls.py    3 Nov 2005 22:40:04 -0000       1.16
+++ rdiff_backup/eas_acls.py    11 Dec 2005 21:48:33 -0000
@@ -271,7 +271,7 @@
 
        def cmp_entry_list(self, l1, l2):
                """True if the lists have same entries.  Assume preordered"""
-               if not l1: return l1 == l2
+               if not l1: return not l2
                if not l2 or len(l1) != len(l2): return 0
                for i in range(len(l1)):
                        type1, namepair1, perms1 = l1[i]




-- 
Ben Escoto

pgpbvUnVII9Zh.pgp
Description: PGP signature