Re: [rdiff-backup-users] problems with doing backup after updating to 0.12.2

[Ben Escoto]

>>>>> "AM" == Arkadiusz Miskiewicz <address@hidden>
>>>>> wrote the following on Sun, 3 Aug 2003 17:06:36 +0200

  AM> I've updated rdiff-backup to 0.12.2 (from 0.11.5) and also
  AM> updated python to 2.3 (from 2.2.3 + recompiled rdiff-backup).
    ...
  AM> Nothing really works. Seems python issue.

Interesting, it seems a fix in python has exposed a bug in
rdiff-backup?  That classmethod stuff has always been pretty esoteric.
This patch should fix that problem, but I still haven't run all the
tests with 2.3 final yet.


-- 
Ben Escoto


===================================================================
RCS file: /cvsroot/rdiff-backup/rdiff-backup/rdiff_backup/backup.py,v
retrieving revision 1.18
diff -u -r1.18 backup.py
--- backup.py   18 Jul 2003 05:11:45 -0000      1.18
+++ backup.py   3 Aug 2003 17:54:11 -0000
@@ -50,7 +50,7 @@
 
 class SourceStruct:
        """Hold info used on source side when backing up"""
-       source_select = None # will be set to source Select iterator
+       _source_select = None # will be set to source Select iterator
        def set_source_select(cls, rpath, tuplelist, *filelists):
                """Initialize select object using tuplelist
 
@@ -59,7 +59,7 @@
                connection.  Otherwise we will get an error because a list
                containing files can't be pickled.
 
-               Also, cls.source_select needs to be cached so get_diffs below
+               Also, cls._source_select needs to be cached so get_diffs below
                can retrieve the necessary rps.
 
                """
@@ -67,15 +67,15 @@
                sel.ParseArgs(tuplelist, filelists)
                sel.set_iter()
                cache_size = Globals.pipeline_max_length * 3 # to and from+leewa
y
-               cls.source_select = rorpiter.CacheIndexable(sel, cache_size)
+               cls._source_select = rorpiter.CacheIndexable(sel, cache_size)
 
        def get_source_select(cls):
                """Return source select iterator, set by set_source_select"""
-               return cls.source_select
+               return cls._source_select
 
        def get_diffs(cls, dest_sigiter):
                """Return diffs of any files with signature in dest_sigiter"""
-               source_rps = cls.source_select
+               source_rps = cls._source_select
                error_handler = robust.get_error_handler("ListError")
                def attach_snapshot(diff_rorp, src_rp):
                        """Attach file of snapshot to diff_rorp, w/ error checki
ng"""

pgp1idnn__pQs.pgp
Description: PGP signature