rdiff-backup-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[rdiff-backup-users] making intermediate destination directories


From: Keith Edmunds
Subject: [rdiff-backup-users] making intermediate destination directories
Date: Wed, 14 May 2003 22:13:34 +0100

I'd like to suggest a small enhancement to rdiff-backup, which is to use
'makedirs' instead of'mkdir' when creating the destination backup
directory. This means that all intermediate directories on the path are
made as well, if necessary (like mkdir -p in Linux).

The reason I suggest this is that if I issue the following command:

        rdiff-backup /usr/local remote_machine::/backups/usr/local

then the directory "/backups/usr" (at least) must exist already. If
'makedirs' were used, that creates the entire path required.

Maybe there might be security concerns (someone could backup to
/usr/bin), but these can be overcome with either the existing
--restrict* switches, or by perhaps having an explicit --make-paths
switch.

I had a quick grep through the code and there are only ten places where
mkdir is used (and, although I haven't looked, I suspect only a few of
them would need to be changed). Thoughts?


-- 
Keith Edmunds




reply via email to

[Prev in Thread] Current Thread [Next in Thread]