[Rdiff-backup-bugs] [bug #21106] rdiff-backup trying to access parent directories in restore_set_root

[anonymous]

URL:
  <http://savannah.nongnu.org/bugs/?21106>

                 Summary: rdiff-backup trying to access parent directories in
restore_set_root
                 Project: rdiff-backup
            Submitted by: None
            Submitted on: Tuesday 09/18/2007 at 04:30 UTC
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Hi,

I want to use rdiff-backup on a web hosting account, but I don't have read
access to /home. This causes rdiff-backup to fail when run in (for example)
/home/myuser. Someone else has had this bug before:
http://osdir.com/ml/sysutils.backup.rdiff-backup.general/2006-04/msg00013.html

I tracked down the problem to restore_set_root in Main.py. It tries to call
parent_dir.listdir() even though parent_dir (/home) isn't readable.

Two simple changes fix this bug. Firstly add the following to rpath.py:

def is_readable(self):
        return self.conn.os.access(self.path, self.conn.os.R_OK)

Now add a check to is_readable in restore_set_root in Main.py (around line
601):

  if (parent_dir.isdir() and
+         parent_dir.is_readable() and
          "rdiff-backup-data" in parent_dir.listdir()): break

I can provide a proper diff if you prefer, I'm just feeling lazy.

Alex Chapman




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?21106>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/