ratpoison-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RP] [PATCH] Make focus* commands screen aware.


From: Joseph Mingrone
Subject: Re: [RP] [PATCH] Make focus* commands screen aware.
Date: Sun, 11 Dec 2016 20:15:34 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (berkeley-unix)

Pedro Silva <address@hidden> writes:

> focusright, focusleft, focusup, and focusdown previously worked solely
> within the frame's screen, because their underlying handling logic in
> split.c strictly did not consider their screen offsets.

> This patch introduces 4 new functions, frame_*_abs, which instead report
> the frame's left, right, top, and bottom coordinates offset by it's
> screen arrangement. This allows the use of the focus* commands as
> additional screen navigation tools, and has the added benefit of making
> the find_frame_* functions clearer.
> ---
>  doc/ratpoison.texi |  4 +++-
>  src/frame.c        | 27 ++++++++++++++++++++++++
>  src/frame.h        |  4 ++++
>  src/split.c        | 62 
> +++++++++++++++++++++++++++++++++++-------------------
>  4 files changed, 74 insertions(+), 23 deletions(-)

This is a nice idea.  It makes ratpoison behave similar to StumpWM with respect 
to multiple screens, which I find more intuitive.

I've attached an updated patch, which applies against the xrandr branch.

Attachment: 0001-Update-screen-aware-focus-commands.patch
Description: Updated screen-aware focus* patch

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]