Re: [RP] Fix for ratpoison OpenBSD-Port

[Matthias Kilian]

[Cc'd to the maintainer of the OpenBSD port]

On Thu, Oct 07, 2004 at 01:10:42PM -0700, Shawn Betts wrote:
> I just added code to CVS to add an '=' and pass it to putenv. Can you
> test it on your OpenBSD box? I don't have one.

Tested on OpenBSD 3.6.

It works, but there's a memory leak. May I suggest an additional
patch? [untested, but it's trivial]

diff -u -r1.202 actions.c
--- actions.c   5 Oct 2004 23:29:39 -0000       1.202
+++ actions.c   7 Oct 2004 19:56:55 -0000
@@ -2773,8 +2773,8 @@
   s = sbuf_new(0);
   sbuf_copy (s, data);
   sbuf_concat (s, "=");
-  str = sbuf_free_struct (s);
-  putenv (str);
+  putenv (sbuf_get(s));
+  sbuf_free(s);
 
   return NULL;
 }


Ciao,
        Kili