[Quilt-dev] [PATCH] test: Fix a race condition

[Jean Delvare]

The test suite does not differentiate between stdout and stderr. When
messages are printed to both, the order in which they will reach us
is apparently not guaranteed. Ideally this would be deterministic, but
until then, explicitly test stdout and stderr separately in the test
case itself. Otherwise the test suite fails randomly, which is a pain
for distribution package maintainers.

This fixes bug #63651 reported by Ross Burton:
https://savannah.nongnu.org/bugs/index.php?63651

Signed-off-by: Jean Delvare <jdelvare@suse.de>
---
 test/faildiff.test |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- quilt.orig/test/faildiff.test
+++ quilt/test/faildiff.test
@@ -27,8 +27,9 @@ What happens on binary files?
        > File test.bin added to patch %{P}test.diff
 
        $ printf "\\003\\000\\001" > test.bin
-       $ quilt diff -pab --no-index
+       $ quilt diff -pab --no-index 2>/dev/null
        >~ (Files|Binary files) a/test\.bin and b/test\.bin differ
+       $ quilt diff -pab --no-index >/dev/null
        > Diff failed on file 'test.bin', aborting
        $ echo %{?}
        > 1


-- 
Jean Delvare
SUSE L3 Support