[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Quilt-dev] [PATCH] inspect-wrapper: Resolve links in source path if
|
From: |
Jean Delvare |
|
Subject: |
Re: [Quilt-dev] [PATCH] inspect-wrapper: Resolve links in source path if rpmbuild did so |
|
Date: |
Tue, 24 Nov 2020 13:41:34 +0100 |
|
User-agent: |
Evolution 3.34.4 |
On Mon, 2020-11-23 at 16:56 +0100, Jean Delvare wrote:
> Apparently rpmbuild will resolve symbolic links to patch files before
> passing them to the patch utility. We need to do the same before we
> attempt to turn absolute paths into relative paths for the series
> file, otherwise we will fail to match the common path.
After further analysis, it turns out that rpmbuild is not to blame. The
resolution of symbolic links is done by the kernel itself when we
figure out (via procfs) the path to the patch file which was passed to
the patch utility through stdin. Illustration:
$ readlink /proc/self/fd/0 < /tmp/foo/openSUSE:Factory/quilt/expand.diff
/tmp/openSUSE:Factory/quilt/expand.diff
So a better fix is possible. Working on it.
--
Jean Delvare
SUSE L3 Support