quilt-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Quilt-dev] [patch] verbose error message when the serie file does n


From: Martin Panter
Subject: Re: [Quilt-dev] [patch] verbose error message when the serie file does not exist
Date: Mon, 23 Mar 2020 13:28:33 +1100

On Mon, 23 Mar 2020 at 10:06, Martin Quinson
<address@hidden> wrote:
> Here is a first very simple patch that I hope will be rather
> consensual. It simply displays an error message when the serie file
> does not exist (provided that the verbose option is activated).  This
> was requested back in 2006 by a user who wanted his own PEBKAC to be
> explicitely reported.
>
> Would it be acceptable for inclusion?

I think this error message has helped me in the past when I forget to
jump to the right directory.

> Description: verbose error message when the series file does not exist
>  patchfns.in(cat_series): Displays an error message when the $SERIES
>  file does not exist, and when run in verbose mode.
> Bug-Debian: https://bugs.debian.org/369908
>
> ---
>  quilt/scripts/patchfns.in |    3 +++
>  1 file changed, 3 insertions(+)
>
> --- a/quilt/scripts/patchfns.in
> +++ b/quilt/scripts/patchfns.in
> @@ -358,6 +358,9 @@
>                 sed -e '/^#/d' -e 's/^[ '$'\t'']*//' \
>                     -e 's/[ '$'\t''].*//' -e '/^$/d' "$SERIES"
>         else
> +               if [ "$opt_verbose" ]; then
> +                       echo $"No series file found\n" >&2
> +               fi

Aha! so that's where this funny error message comes from on Debian.
Can you remove the \n garbage at the end of it? The "echo" command
adds its own newline at the end of the message anyway.

$ quilt series -v
No series file found\n



reply via email to

[Prev in Thread] Current Thread [Next in Thread]