Re: [Quilt-dev] [PATCH] mail: Unbreak threading

[Thomas Gleixner]

On Mon, 4 Jun 2018, Thomas Gleixner wrote:

> The Message-ID extraction from the cover letter fails because the message
> generator uses 'Message-Id' while the extraction uses 'Message-ID'. formail
> did not care, but the extraction sed magic cares. As a consequence
> threading of the mails is broken.
> 
> Use 'Message-ID' consistently all over the place.
> 
> Fixes: 1d659bebaf3d ("quilt/mail: Remove procmail dependency")
> Signed-off-by: Thomas Gleixner <address@hidden>

I noticed that the patch has been applied already. Thanks for that.

Though I disagree with the rewritten changelog:

  (The mail threading broken by commit 1d659beb "quilt/mail: Remove
  procmail dependency" was already fixed by commit 360b85e1 "mail: Fix
  patch set threading".)

That's blantantly wrong. commit 360b85e1 fixes absolutely nothing because
it merily adds -n to the sed invocation which does not at all fix the
uppercase/lowercase mismatch of the supplied header search string
'Message-ID' and the header 'Message-Id' in the mail generator which
creates the cover letter from which the message id should be extracted.

Thanks,

        tglx