quilt-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Quilt-dev] [PATCH 4/4] Force the sender in the "quilt mail" test su


From: Jean Delvare
Subject: Re: [Quilt-dev] [PATCH 4/4] Force the sender in the "quilt mail" test suite
Date: Mon, 01 Oct 2012 02:28:43 +0200

Hi Raphael,

Le mercredi 29 février 2012 à 20:37 +0100, Raphael Hertzog a écrit :
> On Wed, 29 Feb 2012, Jean Delvare wrote:
> > No objection in principle, but can we stick to address@hidden for fake 
> > from/sender address as the test suite already uses? noreply.org is an 
> > existing domain so it seems unfair to use it, even if only in a test 
> > suite.
> 
> Sure, updated patch attached.

I was - finally - about to apply this patch, when I noticed that
test/mail.test has 4 occurrences of "quilt mail" and your patch adds
--sender to the first 2 only.  We want to add it to all 4 occurrences,
don't we? Or am I missing an obvious reason why the last two don't need
it?

Thanks,
-- 
Jean Delvare
Suse L3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]