Re: [Quilt-dev] [PATCH] Add refresh hook quilt_refresh_check()

[Dean Roehrich]

On Wed, Dec 10, 2008 at 04:26:09PM +0100, Jan Blunck wrote:
> This patch adds a hook function that is called during refresh. At that point
> in time an user specified script can be called. If the hook function signals
> no error the refresh is permitted.

I guess I don't understand why anyone would want to fail the refresh.  I'm
often using refresh for incremental work--even when I don't yet have code that
compiles I still have to refresh so I can pop and go work on some other patch.

Wouldn't it make more sense to have your sign-off/acked-by hook attached to
the 'mail' operation?  Why would the act of typing 'refresh' equate to
acknowledging a patch?

Dean