Re: [Quilt-dev] error with "Signed-off-by" names not being proper email names

[Andreas Gruenbacher]

On Saturday, 25 March 2006 16:46, Jean Delvare wrote:
> Hi Greg, Andreas,
>
> > > Current quilt has heuristics built in for handling most patches well
> > > enough. As part of those heuristics, it adds addresses from To: lines
> > > in patch headers to the To: mail header, and Signed-off-by:,
> > > Acked-by:, and Cc: to the Cc: mail header. It doesn't check those
> > > addresses for validity or try to quote them, so that's probably what
> > > causes this problem.
> >
> > It's checking them for validity and dieing when they aren't in the
> > proper format.
>
> I think sendmail is checking and dying, not quilt. Quilt actually
> doesn't seem to make any check.

quilt/scripts/edmail.in checks that.

> > > Probably it would be good to be more liberal with recipient addresses
> > > in general, and quote them properly automatically.
> >
> > That would be nice :)
>
> Here is a naive patch trying to add quotes when needed:
> [...]
>
> Basically, it breaks recipient strings into name and address, and adds
> double quotes around the name if it contains non-alphanumeric,
> non-blank characters.

I'd rather fix it in quilt/scripts/edmail.in.

> Andreas, is it acceptable or do you have more elaborated plans?

Recipient name encoding is a bit tricky; when there are non-ansi characters, 
the name needs to be encoded word-wise like so,
    Andreas =?iso-8859-1?q?Gr=FCnbacher?= <address@hidden>
and for that we need to assume which character the 8-bit characters in the 
input message are from.

> As a side note, I have noticed that "quilt mail" creates an empty file
> named "0". Any idea why it does that? That's a bug, hm?

Because of this glitch:
--- quilt/mail.in
+++ quilt/mail.in
@@ -244 +244 @@
-                       if [ ${#para} > 0 -a ${#para} -lt 150 ]
+                       if [ ${#para} -gt 0 -a ${#para} -lt 150 ]

Thanks,
Andreas