[Quilt-dev] changed permissions on .pc/applied-patches

[Jean Delvare]

Hi all,

Today I noticed that the permissions on .pc/applied-patches had changed
to 600 for no apparent reason. Investigating a bit further revealed that
this was a side effect of "quilt pop" and "quilt rename", because of the
way temporary files are used in remove_from_db() and rename_in_db(),
respectively.

Proposed patch follows, seems to work just fine for me. I'll apply it
soon unless someone has an objection.

Index: scripts/patchfns.in
===================================================================
RCS file: /cvsroot/quilt/quilt/scripts/patchfns.in,v
retrieving revision 1.67
diff -u -r1.67 patchfns.in
--- scripts/patchfns.in 26 Aug 2005 09:58:02 -0000      1.67
+++ scripts/patchfns.in 30 Aug 2005 17:09:49 -0000
@@ -277,7 +277,8 @@
        ' $DB > $tmpfile
        if [ $? -eq 0 ]
        then
-               mv -f $tmpfile $DB
+               cat $tmpfile > $DB
+               rm -f $tmpfile
        else
                rm -f $tmpfile
                return 1
@@ -413,7 +414,7 @@
        if tmpfile=$(gen_tempfile)
        then
                grep -v -E "^$(quote_re $patch)\$" $DB > $tmpfile
-               mv -f $tmpfile $DB
+               cat $tmpfile > $DB
                rm -f $tmpfile
                [ -s $DB ] || rm -f $DB
        fi


-- 
Jean Delvare