[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/6] hw/net: cadence_gem: Fix MDIO_OP_xxx values
From: |
Michael Tokarev |
Subject: |
[PULL 4/6] hw/net: cadence_gem: Fix MDIO_OP_xxx values |
Date: |
Fri, 5 Jan 2024 22:30:36 +0300 |
From: Bin Meng <bmeng@tinylab.org>
Testing upstream U-Boot with 'sifive_u' machine we see:
=> dhcp
ethernet@10090000: PHY present at 0
Could not get PHY for ethernet@10090000: addr 0
phy_connect failed
This has been working till QEMU 8.1 but broken since QEMU 8.2.
Fixes: 1b09eeb122aa ("hw/net/cadence_gem: use FIELD to describe PHYMNTNC
register fields")
Reported-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Bin Meng <bmeng@tinylab.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
hw/net/cadence_gem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
index d7b7b134b0..ec7bf562e5 100644
--- a/hw/net/cadence_gem.c
+++ b/hw/net/cadence_gem.c
@@ -199,8 +199,8 @@ REG32(PHYMNTNC, 0x34) /* Phy Maintenance reg */
FIELD(PHYMNTNC, PHY_ADDR, 23, 5)
FIELD(PHYMNTNC, OP, 28, 2)
FIELD(PHYMNTNC, ST, 30, 2)
-#define MDIO_OP_READ 0x3
-#define MDIO_OP_WRITE 0x2
+#define MDIO_OP_READ 0x2
+#define MDIO_OP_WRITE 0x1
REG32(RXPAUSE, 0x38) /* RX Pause Time reg */
REG32(TXPAUSE, 0x3c) /* TX Pause Time reg */
--
2.39.2
- [PULL 0/6] Trivial patches for 2024-01-05, Michael Tokarev, 2024/01/05
- [PULL 1/6] target/riscv: Fix mcycle/minstret increment behavior, Michael Tokarev, 2024/01/05
- [PULL 2/6] chardev/char.c: fix "abstract device type" error message, Michael Tokarev, 2024/01/05
- [PULL 3/6] audio/audio.c: remove trailing newline in error_setg, Michael Tokarev, 2024/01/05
- [PULL 4/6] hw/net: cadence_gem: Fix MDIO_OP_xxx values,
Michael Tokarev <=
- [PULL 5/6] edu: fix DMA range upper bound check, Michael Tokarev, 2024/01/05
- [PULL 6/6] docs: use "buses" rather than "busses", Michael Tokarev, 2024/01/05
- Re: [PULL 0/6] Trivial patches for 2024-01-05, Peter Maydell, 2024/01/08