[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 6/6] hw/char/parallel: Replace string literals by TYPE_ISA_PAR
From: |
Bernhard Beschow |
Subject: |
[PATCH v2 6/6] hw/char/parallel: Replace string literals by TYPE_ISA_PARALLEL macro |
Date: |
Sun, 21 May 2023 14:30:49 +0200 |
Rather than using a string literal which is prone to typos let's use a macro
instead which is caught by the compiler if mistyped.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/char/parallel-isa.c | 3 ++-
hw/isa/isa-superio.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/char/parallel-isa.c b/hw/char/parallel-isa.c
index 1ccbb96e70..ab0f879998 100644
--- a/hw/char/parallel-isa.c
+++ b/hw/char/parallel-isa.c
@@ -13,6 +13,7 @@
#include "sysemu/sysemu.h"
#include "hw/isa/isa.h"
#include "hw/qdev-properties.h"
+#include "hw/char/parallel-isa.h"
#include "hw/char/parallel.h"
#include "qapi/error.h"
@@ -21,7 +22,7 @@ static void parallel_init(ISABus *bus, int index, Chardev
*chr)
DeviceState *dev;
ISADevice *isadev;
- isadev = isa_new("isa-parallel");
+ isadev = isa_new(TYPE_ISA_PARALLEL);
dev = DEVICE(isadev);
qdev_prop_set_uint32(dev, "index", index);
qdev_prop_set_chr(dev, "chardev", chr);
diff --git a/hw/isa/isa-superio.c b/hw/isa/isa-superio.c
index c81bfe58ef..3baa9777be 100644
--- a/hw/isa/isa-superio.c
+++ b/hw/isa/isa-superio.c
@@ -20,6 +20,7 @@
#include "hw/isa/superio.h"
#include "hw/qdev-properties.h"
#include "hw/input/i8042.h"
+#include "hw/char/parallel-isa.h"
#include "hw/char/serial.h"
#include "trace.h"
@@ -51,7 +52,7 @@ static void isa_superio_realize(DeviceState *dev, Error
**errp)
} else {
name = g_strdup_printf("parallel%d", i);
}
- isa = isa_new("isa-parallel");
+ isa = isa_new(TYPE_ISA_PARALLEL);
d = DEVICE(isa);
qdev_prop_set_uint32(d, "index", i);
if (k->parallel.get_iobase) {
--
2.40.1
- [PATCH v2 0/6] Trivial cleanups, Bernhard Beschow, 2023/05/21
- [PATCH v2 1/6] hw/timer/i8254_common: Share "iobase" property via base class, Bernhard Beschow, 2023/05/21
- [PATCH v2 3/6] hw/isa/i82378: Remove unused "io" attribute, Bernhard Beschow, 2023/05/21
- [PATCH v2 4/6] hw/char/parallel: Export ParallelState, Bernhard Beschow, 2023/05/21
- [PATCH v2 5/6] hw/char/parallel-isa: Export ISAParallelState, Bernhard Beschow, 2023/05/21
- [PATCH v2 6/6] hw/char/parallel: Replace string literals by TYPE_ISA_PARALLEL macro,
Bernhard Beschow <=
- [PATCH v2 2/6] hw/arm/omap: Remove unused omap_uart_attach(), Bernhard Beschow, 2023/05/21