[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-8.0] block/nbd: Add missing <qemu/bswap.h> include

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH-for-8.0] block/nbd: Add missing <qemu/bswap.h> include
Date: Sat, 26 Nov 2022 00:13:55 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2

On 11/25/22 20:53, Philippe Mathieu-Daudé wrote:
The inlined nbd_readXX() functions call beXX_to_cpu(), themselves
declared in <qemu/bswap.h>. This fixes when refactoring:

   In file included from ../../block/nbd.c:44:
   include/block/nbd.h: In function 'nbd_read16':
   include/block/nbd.h:383:12: error: implicit declaration of function 
'be16_to_cpu' [-Werror=implicit-function-declaration]
     383 |     *val = be##bits##_to_cpu(*val);                                  
         |            ^~
   include/block/nbd.h:387:1: note: in expansion of macro 'DEF_NBD_READ_N'
     387 | DEF_NBD_READ_N(16) /* Defines nbd_read16(). */
         | ^~~~~~~~~~~~~~

Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]