[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/19] hw/9pfs: Drop unnecessary *xattr wrapper API declar
From: |
Greg Kurz |
Subject: |
Re: [PATCH v2 02/19] hw/9pfs: Drop unnecessary *xattr wrapper API declarations |
Date: |
Fri, 18 Nov 2022 09:42:26 +0100 |
On Fri, 11 Nov 2022 12:22:08 +0800
Bin Meng <bin.meng@windriver.com> wrote:
> These are not used anywhere in the source tree. Drop them.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
This one could even go through the trivial tree right
away IMHO.
Reviewed-by: Greg Kurz <groug@kaod.org>
> (no changes since v1)
>
> hw/9pfs/9p-util.h | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/hw/9pfs/9p-util.h b/hw/9pfs/9p-util.h
> index c3526144c9..ccfc8b1cb3 100644
> --- a/hw/9pfs/9p-util.h
> +++ b/hw/9pfs/9p-util.h
> @@ -90,19 +90,8 @@ static inline int errno_to_dotl(int err) {
>
> #ifdef CONFIG_DARWIN
> #define qemu_fgetxattr(...) fgetxattr(__VA_ARGS__, 0, 0)
> -#define qemu_lgetxattr(...) getxattr(__VA_ARGS__, 0, XATTR_NOFOLLOW)
> -#define qemu_llistxattr(...) listxattr(__VA_ARGS__, XATTR_NOFOLLOW)
> -#define qemu_lremovexattr(...) removexattr(__VA_ARGS__, XATTR_NOFOLLOW)
> -static inline int qemu_lsetxattr(const char *path, const char *name,
> - const void *value, size_t size, int flags) {
> - return setxattr(path, name, value, size, 0, flags | XATTR_NOFOLLOW);
> -}
> #else
> #define qemu_fgetxattr fgetxattr
> -#define qemu_lgetxattr lgetxattr
> -#define qemu_llistxattr llistxattr
> -#define qemu_lremovexattr lremovexattr
> -#define qemu_lsetxattr lsetxattr
> #endif
>
> static inline void close_preserve_errno(int fd)
- Re: [PATCH v2 02/19] hw/9pfs: Drop unnecessary *xattr wrapper API declarations,
Greg Kurz <=