[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 30/30] migration: Block migration comment or code is wrong
From: |
Juan Quintela |
Subject: |
[PULL 30/30] migration: Block migration comment or code is wrong |
Date: |
Tue, 15 Nov 2022 16:35:14 +0100 |
And it appears that what is wrong is the code. During bulk stage we
need to make sure that some block is dirty, but no games with
max_size at all.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
migration/block.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index 3577c815a9..4347da1526 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -880,8 +880,8 @@ static void block_save_pending(QEMUFile *f, void *opaque,
uint64_t max_size,
blk_mig_unlock();
/* Report at least one block pending during bulk phase */
- if (pending <= max_size && !block_mig_state.bulk_completed) {
- pending = max_size + BLK_MIG_BLOCK_SIZE;
+ if (!pending && !block_mig_state.bulk_completed) {
+ pending = BLK_MIG_BLOCK_SIZE;
}
trace_migration_block_save_pending(pending);
--
2.38.1
- [PULL 20/30] migration: Yield bitmap_mutex properly when sending/sleeping, (continued)
- [PULL 20/30] migration: Yield bitmap_mutex properly when sending/sleeping, Juan Quintela, 2022/11/15
- [PULL 21/30] migration: Use atomic ops properly for page accountings, Juan Quintela, 2022/11/15
- [PULL 23/30] migration: Introduce pss_channel, Juan Quintela, 2022/11/15
- [PULL 19/30] migration: Remove RAMState.f references in compression code, Juan Quintela, 2022/11/15
- [PULL 17/30] migration: Cleanup xbzrle zero page cache update logic, Juan Quintela, 2022/11/15
- [PULL 18/30] migration: Trivial cleanup save_page_header() on same block check, Juan Quintela, 2022/11/15
- [PULL 24/30] migration: Add pss_init(), Juan Quintela, 2022/11/15
- [PULL 25/30] migration: Make PageSearchStatus part of RAMState, Juan Quintela, 2022/11/15
- [PULL 22/30] migration: Teach PSS about host page, Juan Quintela, 2022/11/15
- [PULL 27/30] migration: Send requested page directly in rp-return thread, Juan Quintela, 2022/11/15
- [PULL 30/30] migration: Block migration comment or code is wrong,
Juan Quintela <=
- [PULL 29/30] migration: Drop rs->f, Juan Quintela, 2022/11/15
- [PULL 28/30] migration: Remove old preempt code around state maintainance, Juan Quintela, 2022/11/15
- [PULL 26/30] migration: Move last_sent_block into PageSearchStatus, Juan Quintela, 2022/11/15
- Re: [PULL 00/30] Next patches, Daniel P . Berrangé, 2022/11/15
- Re: [PULL 00/30] Next patches, Stefan Hajnoczi, 2022/11/15
- Re: [PULL 00/30] Next patches, Stefan Hajnoczi, 2022/11/15