[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] acpi/tests/avocado/bits: some misc fixes and spelling correc

From: Thomas Huth
Subject: Re: [PATCH] acpi/tests/avocado/bits: some misc fixes and spelling corrections
Date: Fri, 11 Nov 2022 10:06:06 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 11/11/2022 09.52, Ani Sinha wrote:
Most of the changes are cosmetic. The bits test timeout has now been increased
to 90 seconds in order to accommodate slower systems and fewer unnecessary
failures. One spelling correction in docs along with removal of the reference
to non-existent README file.

CC: Thomas Huth <thuth@redhat.com>
CC: qemu-trivial@nongnu.org
Signed-off-by: Ani Sinha <ani@anisinha.ca>
  docs/devel/acpi-bits.rst   | 3 +--
  tests/avocado/acpi-bits.py | 5 +++--
  2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/docs/devel/acpi-bits.rst b/docs/devel/acpi-bits.rst
index c9564d871a..a9020adb2d 100644
--- a/docs/devel/acpi-bits.rst
+++ b/docs/devel/acpi-bits.rst
@@ -41,7 +41,6 @@ Under ``tests/avocado/`` as the root we have:
     │ │ ├── smbios.py2
     │ │ ├── testacpi.py2
     │ │ └── testcpuid.py2

That leaves the second "|" dangling around ... should those second pipe characters now be removed, too?

-   │ └── README
     ├── acpi-bits.py
* ``tests/avocado``:
@@ -132,7 +131,7 @@ Under ``tests/avocado/`` as the root we have:
(a) They are python2.7 based scripts and not python 3 scripts.
     (b) They are run from within the bios bits VM and is not subjected to QEMU
-       build/test python script maintainance and dependency resolutions.
+       build/test python script maintenance and dependency resolutions.

FWIW, this will also be fixed by Stefan Weil's current pending doc update patch.

     (c) They need not be loaded by avocado framework when running tests.
diff --git a/tests/avocado/acpi-bits.py b/tests/avocado/acpi-bits.py
index 8745a58a76..5ebe8c14a2 100644
--- a/tests/avocado/acpi-bits.py
+++ b/tests/avocado/acpi-bits.py
@@ -385,8 +385,9 @@ def test_acpi_smbios_bits(self):
          # biosbits has been configured to run all the specified test suites
          # in batch mode and then automatically initiate a vm shutdown.
-        # sleep for maximum of one minute
-        max_sleep_time = time.monotonic() + 60
+        # sleep for maximum of a minute and a half to accomomodate even slower


+        # test setups.
+        max_sleep_time = time.monotonic() + 90
          while self._vm.is_running() and time.monotonic() < max_sleep_time:


reply via email to

[Prev in Thread] Current Thread [Next in Thread]